Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22671#discussion_r223775935
  
    --- Diff: 
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
 ---
    @@ -332,7 +332,9 @@ class KafkaSinkSuite extends StreamTest with 
SharedSQLContext with KafkaTest {
         var ex: Exception = null
         try {
           ex = intercept[StreamingQueryException] {
    -        writer = createKafkaWriter(input.toDF(), withTopic = Some(topic))()
    +        writer = createKafkaWriter(input.toDF(),
    --- End diff --
    
    In retrospect 1000 may have been too low - that could cause flakiness if 
the test runner is slow or something and it legitimately takes a second or two 
for Kafka to respond. 10k definitely should work, and I'd be fine with 1k if 
we're really worried about test time here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to