Github user rezasafi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22612#discussion_r223786195
  
    --- Diff: 
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
    @@ -59,6 +60,43 @@ case object JVMOffHeapMemory extends ExecutorMetricType {
       }
     }
     
    +case object ProcessTreeJVMRSSMemory extends ExecutorMetricType {
    +  override private[spark] def getMetricValue(memoryManager: 
MemoryManager): Long = {
    +    ExecutorMetricType.pTreeInfo.updateAllMetrics()
    --- End diff --
    
    I changed this to use a map instead of an array of metrics to implement #2 
of what @squito suggested


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to