Github user rezasafi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r223934270
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala ---
@@ -28,35 +30,63 @@ import org.apache.spark.metrics.ExecutorMetricType
@DeveloperApi
class ExecutorMetrics private[spark] extends Serializable {
- // Metrics are indexed by MetricGetter.values
- private val metrics = new Array[Long](ExecutorMetricType.values.length)
+ private var metrics = mutable.Map.empty[String, Long]
--- End diff --
I think I have found a better solution to use an array like before and make
use of a map for clarity. I will try to push this new solution by Wednesday
night after finishing the tests. Thank you very much.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
