Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r224230450 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -433,4 +442,39 @@ class ClientSuite extends SparkFunSuite with Matchers { classpath(env) } + private def testResourceRequest(expectedResources: Seq[(String, Long)], --- End diff -- Repeating the comment since github doesn't re-open the original thread: This isn't fixed yet. You're still passing in the expected resources, which are expected to match the hardcoded configs that are set in this method
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org