Github user szyszy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20761#discussion_r224245968
  
    --- Diff: 
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
 ---
    @@ -433,4 +442,39 @@ class ClientSuite extends SparkFunSuite with Matchers {
         classpath(env)
       }
     
    +  private def testResourceRequest(expectedResources: Seq[(String, Long)],
    --- End diff --
    
    Fair enough. I decided to pass in the sparkConf, the list of known 
resources and the expected resources and their values, so the testcase is more 
clear now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to