Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22259#discussion_r224263116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -47,7 +48,8 @@ case class ScalaUDF(
inputTypes: Seq[DataType] = Nil,
udfName: Option[String] = None,
nullable: Boolean = true,
- udfDeterministic: Boolean = true)
+ udfDeterministic: Boolean = true,
+ nullableTypes: Seq[Boolean] = Nil)
--- End diff --
I see, you are saying that some UDF needed to declare nullable types but
didn't? I made the param optional to try to make 'migration' easier and avoid
changing the signature much. But, the test you point to, doesn't it pass? are
you saying it should not pass?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
