Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22259#discussion_r224540341
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -47,7 +48,8 @@ case class ScalaUDF(
inputTypes: Seq[DataType] = Nil,
udfName: Option[String] = None,
nullable: Boolean = true,
- udfDeterministic: Boolean = true)
+ udfDeterministic: Boolean = true,
+ nullableTypes: Seq[Boolean] = Nil)
--- End diff --
Yeah I could see an argument that it need not block release. The
functionality works as intended, at least.
Would you change it again in 2.4.1? If not then we decide to just keep this
behavior. Let's say at least get this in if there is a new RC.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
