Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3213#discussion_r20462981
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDD.scala ---
    @@ -131,6 +134,80 @@ class SchemaRDD(
        */
       lazy val schema: StructType = queryExecution.analyzed.schema
     
    +  /** Transforms a single Row to JSON using Jackson
    +    *
    +    * @param jsonFactory a JsonFactory object to construct a JsonGenerator
    +    * @param rowSchema the schema object used for conversion
    +    * @param row The row to convert
    +    */
    +  private def rowToJSON(rowSchema: StructType, jsonFactory: 
JsonFactory)(row: Row): String = {
    --- End diff --
    
    I think it would be better to put this in the `object` in the `json` 
package to avoid more `SQLContext` bloat.  (Admittedly we have not been very 
good about this in the past, but I'd like to avoid it getting worse)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to