Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/3213#issuecomment-63376043
Thanks -- I'll clean up the style issues straight away. I'm glad to see
this getting close to finished.
As for additional tests, I'd been thinking along the same lines. However,
I'm not sure where they should live: SQLQuerySuite or JsonSuite. I think
if it's JsonRDD compared with rehydrated toJSON output, it should be in
JsonSuite.
Cheers,
Dan
On Mon, Nov 17, 2014 at 12:43 PM, Michael Armbrust <notificati...@github.com
> wrote:
> A few minor style comments. Also, regarding testing: it seems like a
> really good way to get better coverage with little effort would be to just
> round-trip a bunch of our existing datasets though this code path.
> Basically just compare the results of "json data" -> jsonRDD with "json
> data" -> jsonRDD -> toJSON -> jsonRDD using the checkAnswer function.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3213#issuecomment-63372210>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
