Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22790#discussion_r228211495 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -109,7 +109,7 @@ class BisectingKMeansModel private[clustering] ( @Since("2.0.0") override def save(sc: SparkContext, path: String): Unit = { - BisectingKMeansModel.SaveLoadV1_0.save(sc, this, path) + BisectingKMeansModel.SaveLoadV2_0.save(sc, this, path) } override protected def formatVersion: String = "1.0" --- End diff -- I'd say yes, but actually this is never used. I think we can actually remove this from the trait.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org