Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22598#discussion_r228665965
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
 ---
    @@ -66,7 +66,8 @@ private[spark] class HadoopDelegationTokenManager(
       private def getDelegationTokenProviders: Map[String, 
HadoopDelegationTokenProvider] = {
         val providers = Seq(new HadoopFSDelegationTokenProvider(fileSystems)) 
++
           safeCreateProvider(new HiveDelegationTokenProvider) ++
    -      safeCreateProvider(new HBaseDelegationTokenProvider)
    +      safeCreateProvider(new HBaseDelegationTokenProvider) ++
    +      safeCreateProvider(new KafkaDelegationTokenProvider)
    --- End diff --
    
    It shouldn't be disabled by default.
    
    I think it's better to just remove the list of provides from the scaladoc. 
That's not really helpful in any case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to