Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r228674142
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -66,7 +66,8 @@ private[spark] class HadoopDelegationTokenManager(
private def getDelegationTokenProviders: Map[String,
HadoopDelegationTokenProvider] = {
val providers = Seq(new HadoopFSDelegationTokenProvider(fileSystems))
++
safeCreateProvider(new HiveDelegationTokenProvider) ++
- safeCreateProvider(new HBaseDelegationTokenProvider)
+ safeCreateProvider(new HBaseDelegationTokenProvider) ++
+ safeCreateProvider(new KafkaDelegationTokenProvider)
--- End diff --
> if this config is set the spark-sql-kafka libraries needs to be in the
class path as well
That's actually an argument against disabling it by default. If you set
that config and don't have the libs in the classpath, you should either:
- get nothing (e.g. current HBase behavior)
- get an error because the libraries are not present
But disabling it by default just means you'd have 3 different things to do
to enable this, instead of two.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
