Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22947#discussion_r230741956
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
 ---
    @@ -66,6 +66,8 @@ case class AssertTrue(child: Expression) extends 
UnaryExpression with ImplicitCa
     
       override def nullable: Boolean = true
     
    +  override lazy val deterministic: Boolean = false
    --- End diff --
    
    hmm, this two expressions are very commonly used in other expressions' 
children. Making them non-deterministic will make such expressions used them as 
non-deterministic too, e.g., encoders. It might have big impact.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to