Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22947#discussion_r230743943
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
 ---
    @@ -66,6 +66,8 @@ case class AssertTrue(child: Expression) extends 
UnaryExpression with ImplicitCa
     
       override def nullable: Boolean = true
     
    +  override lazy val deterministic: Boolean = false
    --- End diff --
    
    yes, that's true. The change may be big indeed. I am open to other 
proposals, as creating a new `sideEffect` flag in the `Expression`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to