Github user rezasafi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r230787617
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -394,9 +394,15 @@ private[spark] object JsonProtocol {
/** Convert executor metrics to JSON. */
def executorMetricsToJson(executorMetrics: ExecutorMetrics): JValue = {
- val metrics = ExecutorMetricType.values.map{ metricType =>
- JField(metricType.name, executorMetrics.getMetricValue(metricType))
- }
+ val metrics = for {
+ (m, _) <- ExecutorMetricType.definedMetricsAndOffset.toSeq
--- End diff --
Thanks for the comment. However the unit test passed even with this. The
failure in the latest run wasn't related to this and it was just because of a
termination. I can work on changing this though to make the order specific if
that is desired.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
