Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r234405667
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -258,11 +258,7 @@ private[ml] object TreeClassifierParams {
private[ml] trait DecisionTreeClassifierParams
extends DecisionTreeParams with TreeClassifierParams
-/**
- * Parameters for Decision Tree-based regression algorithms.
- */
-private[ml] trait TreeRegressorParams extends Params {
--- End diff --
Just looking at this one more time ... hm, isn't `this.type` always
referring to the current class's type? maybe it's some detail of the generated
code and this is essentially a false positive. Or, honestly setImpurity can
just be removed in this change too. It's deprecated for all of these classes. I
don't mind doing that later too; would just avoid these MiMa exclusions too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
