Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r234407043
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -258,11 +258,7 @@ private[ml] object TreeClassifierParams {
private[ml] trait DecisionTreeClassifierParams
extends DecisionTreeParams with TreeClassifierParams
-/**
- * Parameters for Decision Tree-based regression algorithms.
- */
-private[ml] trait TreeRegressorParams extends Params {
--- End diff --
yes, it is AFAIK. I think it is a false positive.
I wouldn't remove it in this change because since this is a bug, this PR
can be backported to 2.4.1 too. I'd do it in a separate change. We would need
anyway to add the MiMa rules for the missing methods, so it doesn't change much
on the exclusions either...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
