Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3372#issuecomment-63737621
Personally, I think this is fine to add. IMO it's slightly over engineered
given how much additional safety it provides. For instance, someone could add a
new piece of state and still forget to clean it up. For this test to catch it,
they'd have to explicitly add their state to these test fixtures. However,
maybe having the code in-line there makes it more obvious that they should do
it.
So happy to have this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
