Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3372#discussion_r20628831
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -40,41 +40,108 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
import JobProgressListener._
+ // Define a handful of type aliases so that data structures' types can
serve as documentation.
+ // These type aliases are public because they're used in the types of
public fields:
+
type JobId = Int
type StageId = Int
type StageAttemptId = Int
+ type PoolName = String
+ type ExecutorId = String
- // How many stages to remember
- val retainedStages = conf.getInt("spark.ui.retainedStages",
DEFAULT_RETAINED_STAGES)
- // How many jobs to remember
- val retailedJobs = conf.getInt("spark.ui.retainedJobs",
DEFAULT_RETAINED_JOBS)
+ // Define all of our state:
--- End diff --
Nit: comment a little unnecessary given that's what this section is
normally for?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
