Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3375#discussion_r20625318
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashOuterJoin.scala
 ---
    @@ -72,53 +72,54 @@ case class HashOuterJoin(
       // iterator for performance purpose.
     
       private[this] def leftOuterIterator(
    -      key: Row, leftIter: Iterable[Row], rightIter: Iterable[Row]): 
Iterator[Row] = {
    +      key: Row, leftRow: Row, rightIter: Iterable[Row]): Iterator[Row] = {
         val joinedRow = new JoinedRow()
    --- End diff --
    
    Can that also be passed in since it will be created per every row in left 
side? The same in below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to