Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/3375#issuecomment-63755562
Generally it looks great to me, the only concern is the memory V.S
computation, particularly it's heavily reply on the scala iterator, maybe we
can optimize that in another PR. But it would be nicer if you can attach a
benchmark result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
