Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23148#discussion_r236421583
  
    --- Diff: pom.xml ---
    @@ -156,6 +156,10 @@
         <commons.collections.version>3.2.2</commons.collections.version>
         <scala.version>2.12.7</scala.version>
         <scala.binary.version>2.12</scala.binary.version>
    +    <scalafmt.version>1.5.1</scalafmt.version>
    --- End diff --
    
    If these are all just used in one place, in the plugin config, I'd just 
inline them below to keep it together. If they get reused in more than one 
place and have to stay synced, then this makes sense.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to