Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236423438 --- Diff: pom.xml --- @@ -156,6 +156,10 @@ <commons.collections.version>3.2.2</commons.collections.version> <scala.version>2.12.7</scala.version> <scala.binary.version>2.12</scala.binary.version> + <scalafmt.version>1.5.1</scalafmt.version> --- End diff -- I moved the scalafmt version inline. The others I think need to stay as parameters so the shell wrapper can override them, to distinguish between the use cases of build pipeline vs contributor fixing code.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org