Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23098#discussion_r236452713
--- Diff: dev/create-release/release-build.sh ---
@@ -110,16 +110,18 @@ fi
# Depending on the version being built, certain extra profiles need to be
activated, and
# different versions of Scala are supported.
BASE_PROFILES="-Pmesos -Pyarn"
-PUBLISH_SCALA_2_10=0
-SCALA_2_10_PROFILES="-Pscala-2.10"
-SCALA_2_11_PROFILES=
+
+# TODO: revisit for Scala 2.13
+
+PUBLISH_SCALA_2_11=1
--- End diff --
I prefer keeping the script in master working against all currently
supported versions. I find it pretty hard to keep things in sync across
different branches, especially if you need to fix things in the middle of an RC
cycle. Having master be the source of truth for this makes some of that pain
goes away, with the cost of some added logic here.
I think the main problem now is that for 3.0 the default Scala version is
different than for 2.4, which is the only added complication I can think of
here...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
