Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23098#discussion_r236736341
--- Diff: dev/create-release/release-build.sh ---
@@ -110,16 +110,18 @@ fi
# Depending on the version being built, certain extra profiles need to be
activated, and
# different versions of Scala are supported.
BASE_PROFILES="-Pmesos -Pyarn"
-PUBLISH_SCALA_2_10=0
-SCALA_2_10_PROFILES="-Pscala-2.10"
-SCALA_2_11_PROFILES=
+
+# TODO: revisit for Scala 2.13
+
+PUBLISH_SCALA_2_11=1
--- End diff --
> if you're releasing 2.3 wouldn't you use the release script as of 2.3?
I started like that when I RM'ed 2.3.1, but the scripts were kinda broken
that I had to fix a bunch of stuff in master. At that point, it didn't make
sense to use the scripts in the 2.3 branch anymore, and keeping them in sync
was kinda wasted effort.
> basically trying to support 2.2+, which seems reasonable?
That's my view. The release scripts in master should be usable for all
non-EOL releases.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
