Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3009#discussion_r20675128
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -195,9 +180,10 @@ private[ui] class StageTableBase(
private[ui] class FailedStageTable(
stages: Seq[StageInfo],
- parent: JobProgressTab,
- killEnabled: Boolean = false)
- extends StageTableBase(stages, parent, killEnabled) {
+ basePath: String,
+ listener: JobProgressListener,
+ isFairScheduler: Boolean)
+ extends StageTableBase(stages, basePath, listener, isFairScheduler,
killEnabled = false) {
--- End diff --
I'd be happy to chat offline about this, but I'm concerned that a
`KillableStagesTable` might be very difficult to implement in our current UI
framework because we don't have a great way to subclass / override portions of
the HTML generation; there's not really any modularization / interfaces / etc.
in any of our markup generation.
I played around with some ideas to improve this over at #2852 but
eventually abandoned that approach because I ran into corner-cases that my
abstraction couldn't cleanly handle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
