Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3009#discussion_r20666049
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -195,9 +180,10 @@ private[ui] class StageTableBase(
private[ui] class FailedStageTable(
stages: Seq[StageInfo],
- parent: JobProgressTab,
- killEnabled: Boolean = false)
- extends StageTableBase(stages, parent, killEnabled) {
+ basePath: String,
+ listener: JobProgressListener,
+ isFairScheduler: Boolean)
+ extends StageTableBase(stages, basePath, listener, isFairScheduler,
killEnabled = false) {
--- End diff --
Not your change, but weird how `killEnabled` is an attribute of the
`StageTableBase`. The right thing to do is to have a `KillableStageTable` or
something. We can fix this later (no action needed on your part)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
