Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23094#discussion_r238239581
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -87,11 +87,32 @@ abstract class JdbcDialect extends Serializable {
def getJDBCType(dt: DataType): Option[JdbcType] = None
/**
- * Quotes the identifier. This is used to put quotes around the
identifier in case the column
- * name is a reserved keyword, or in case it contains characters that
require quotes (e.g. space).
+ * Gets the character used for identifier quoting.
+ */
+ def getIdentifierQuoteCharacter: String = """""""
--- End diff --
btw, I feel we need more general name handling here like
`UnresolvedAttribute. parseAttributeName`
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala#L151
cc: @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
