Github user golovan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23094#discussion_r238246140
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -87,11 +87,32 @@ abstract class JdbcDialect extends Serializable {
def getJDBCType(dt: DataType): Option[JdbcType] = None
/**
- * Quotes the identifier. This is used to put quotes around the
identifier in case the column
- * name is a reserved keyword, or in case it contains characters that
require quotes (e.g. space).
+ * Gets the character used for identifier quoting.
+ */
+ def getIdentifierQuoteCharacter: String = """""""
--- End diff --
> I like a simpler API design; how about splitting an identifier into the
two parts (db and table names) outside `JdbcDialect`? Then, how about applying
`quoteIdentifer` into each name part?
I'll review tonight. If meanwhile you can point me to the best place, you
are welcome!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
