Github user jongyoul commented on the pull request:
https://github.com/apache/spark/pull/3393#issuecomment-64100909
Basically, I thought minimum changes of code is a good way to fix bug, and
refactoring is another issue.
@pwendell I agree that 1. As @tnachen mentioned above, he thought all
acceptedOffers are eventually used. If I can refactor this code, It would be
changed. `usableOffers` and `unusableOffers` are a better idea. then,
`unusableOffers` would be declined explicitly.
2. 3., MesosSchedulerBackend's `CPUS_PER_TASK` and `slaveIdsWithExecutors`
are ambiguous. At first, I think `1 + scheduler.CPUS_PER_TASK` is a better way
than `2 * scheduler.CPUS_PER_TASK`. Assumption of needing one more cpu is
acceptable way because we should consider Mesos' worker is being launched in
case that that executor is not added by `slaveIdsWithExecutors`.
I can fix and refactor that things an more by understanding that Impl
deeply.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
