Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3393#issuecomment-64110335
Thanks @tnachen and @jongyoul for answering questions. It seems like some
of this behavior is just porting code that was in the old version of the Mesos
binding before @tnachen refactored it. So we can hold off on clean-ups and do
it separately.
We should fix the specific issue at hand though for 1.2. Looking back, I'm
curious how this works in Spark 1.1. From what I can tell we never call
`declineOffer` in Spark 1.1. However, we will call something like this:
```
d.launchTasks(Collections.singleton(offers(i).getId), mesosTasks(i),
filters)
```
Where `mesosTasks(i)` is an empty list. @tnachen for mesos is that
equivalent to declining the offer? The relevant code is here:
https://github.com/apache/spark/blob/branch-1.1/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala#L263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
