rezasafi commented on a change in pull request #23306: [SPARK-26357][Core]
Expose executors' procfs metrics to Metrics system
URL: https://github.com/apache/spark/pull/23306#discussion_r241541976
##########
File path:
core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala
##########
@@ -62,7 +62,21 @@ private[spark] class ProcfsMetricsGetter(procfsDir: String
= "/proc/") extends L
SparkEnv.get.conf.get(config.EVENT_LOG_STAGE_EXECUTOR_METRICS)
val shouldLogStageExecutorProcessTreeMetrics =
SparkEnv.get.conf.get(config.EVENT_LOG_PROCESS_TREE_METRICS)
- procDirExists.get && shouldLogStageExecutorProcessTreeMetrics &&
shouldLogStageExecutorMetrics
+ val shouldAddProcessTreeMetricsToMetricsSet =
+ SparkEnv.get.conf.get(config.METRICS_PROCESS_TREE_METRICS)
+ val pickEitherUIOrMetricsSet = shouldLogStageExecutorProcessTreeMetrics ^
+ shouldAddProcessTreeMetricsToMetricsSet
+ val areBothUIMetricsEnabled = shouldLogStageExecutorProcessTreeMetrics &&
+ shouldAddProcessTreeMetricsToMetricsSet
+ if (areBothUIMetricsEnabled) {
+ logWarning("You have enabled " +
+ "both spark.eventLog.logStageExecutorProcessTreeMetrics.enabled" +
+ " and spark.metrics.logStageExecutorProcessTreeMetrics.enabled. This
isn't " +
+ "allowed. As a result Procfs metrics won't be reported to UI or
Metricsset")
+ }
+ (procDirExists.get && shouldLogStageExecutorMetrics &&
pickEitherUIOrMetricsSet) ||
Review comment:
I also think that way is better, since it is simpler. However the pulling
rate and heart beat aren't the same. So I guess we can document that to set
expectations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
