rezasafi commented on a change in pull request #23306: [SPARK-26357][Core]
Expose executors' procfs metrics to Metrics system
URL: https://github.com/apache/spark/pull/23306#discussion_r242278753
##########
File path:
core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala
##########
@@ -37,7 +37,9 @@ private[spark] case class ProcfsMetrics(
pythonVmemTotal: Long,
pythonRSSTotal: Long,
otherVmemTotal: Long,
- otherRSSTotal: Long)
+ otherRSSTotal: Long,
+ timeStamp: Long)
Review comment:
I considered timestamp as a property of the set of metrics, so probably
better to keep it like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
