HyukjinKwon edited a comment on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-447856497 Yes .. that's what I wanted to do and the previous change is really what it needs as is .. I can go back to the previous change. I can simply checkout, pickup commit and rebase stuff. I can't think of other better way than that.. For instance: ```diff abstract class Estimator: - abstract def fit + def fit = fireEvent { fieImpl } + abstract def fitImpl ``` ```diff class Pipleline: - def fit { ... } + def fitImpl { ... } ``` ```diff class OtherClasses: - def fit { ... } + def fitImpl { ... } ``` I can also leave all the changes to estimator's fit(), transform(), etc. (like the original patch ) and don't change other classes to implement `fitImpl`, `transformImpl`, etc. except Pipeline class to reduce diff. For instance: ```diff abstract class Estimator: - abstract def fit + def fit = fireEvent { fieImpl } + abstract def fitImpl ``` ```diff class Pipleline: - def fit { ... } + def fitImpl { ... } ``` ``` class OtherClasses: def fit { ... } ``` Current changes is: ```diff abstract class Estimator: abstract def fit ``` ```diff class Pipleline: - def fit { ... } + def fit = fireEvent { ... } ``` ``` class OtherClasses: def fit { ... } ``` I am not sure which one is easiest way for you guys to take a look.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
