HyukjinKwon edited a comment on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-449199714 Like, if we fix https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala#L181 we should touch each implementation that uses it. If we add another method similarly with it, we should also touch each implementation to wrap it. These will virtually require similar changes as I first proposed - https://github.com/apache/spark/compare/master...HyukjinKwon:SPARK-23674-2?expand=1 I thought the current way is closer to the minimised changes to reach the goal by not invading other codes ...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
