squito commented on a change in pull request #23337: [SPARK-26019][PYSPARK] 
Allow insecure py4j gateways
URL: https://github.com/apache/spark/pull/23337#discussion_r242402973
 
 

 ##########
 File path: python/pyspark/context.py
 ##########
 @@ -112,6 +112,18 @@ def __init__(self, master=None, appName=None, 
sparkHome=None, pyFiles=None,
         ValueError:...
         """
         self._callsite = first_spark_call() or CallSite(None, None, None)
+        if gateway is not None and gateway.gateway_parameters.auth_token is 
None:
+            if conf and conf.get("spark.python.allowInsecurePy4j", "false") == 
"true":
 
 Review comment:
   hmm good point about not reading a file.  I can switch to an environment 
variable -- is that really better for a use case like zeppelin?  neither 
solution seems ideal, but I would really like to keep some check here that 
forces users to opt-in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to