holdenk commented on a change in pull request #23337: [SPARK-26019][PYSPARK]
Allow insecure py4j gateways
URL: https://github.com/apache/spark/pull/23337#discussion_r243724718
##########
File path: python/pyspark/tests.py
##########
@@ -2381,6 +2382,34 @@ def test_startTime(self):
with SparkContext() as sc:
self.assertGreater(sc.startTime, 0)
+ def test_forbid_insecure_gateway(self):
+ # By default, we fail immediately if you try to create a SparkContext
+ # with an insecure gateway
+ gateway = _launch_gateway(insecure=True)
+ with self.assertRaises(Exception) as context:
+ SparkContext(gateway=gateway)
+ self.assertIn("insecure py4j gateway", context.exception.message)
+ self.assertIn("spark.python.allowInsecurePy4j",
context.exception.message)
+ self.assertIn("removed in Spark 3.0", context.exception.message)
+
+ def test_allow_insecure_gateway_with_conf(self):
+ with SparkContext._lock:
+ SparkContext._gateway = None
+ SparkContext._jvm = None
Review comment:
Yeah this logic is sort rough, in spark-testing-base for example in between
tests where folks do not intend to reuse the same Spark context we also clear
some extra properties (although we do reuse the gateway). I think for
environments where folks want multiple SparkContexts from Python on the same
machine they end up using multiple Python processes anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
