holdenk commented on a change in pull request #23337: [SPARK-26019][PYSPARK]
Allow insecure py4j gateways
URL: https://github.com/apache/spark/pull/23337#discussion_r243724870
##########
File path: python/pyspark/accumulators.py
##########
@@ -262,9 +262,10 @@ def authenticate_and_accum_updates():
raise Exception(
"The value of the provided token to the AccumulatorServer
is not correct.")
- # first we keep polling till we've received the authentication token
- poll(authenticate_and_accum_updates)
- # now we've authenticated, don't need to check for the token anymore
+ if auth_token:
Review comment:
nit: I _think_ it's better better style (and consistent with the rest of the
changes) to use `if autho_token is not None`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
