cloud-fan commented on a change in pull request #23388: [SPARK-26448][SQL]
retain the difference between 0.0 and -0.0
URL: https://github.com/apache/spark/pull/23388#discussion_r244079883
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala
##########
@@ -397,27 +397,42 @@ class DatasetPrimitiveSuite extends QueryTest with
SharedSQLContext {
test("special floating point values") {
import org.scalatest.exceptions.TestFailedException
- // Spark treats -0.0 as 0.0
+ // Spark distinguishes -0.0 and 0.0
intercept[TestFailedException] {
- checkDataset(Seq(-0.0d).toDS(), -0.0d)
+ checkDataset(Seq(-0.0d).toDS(), 0.0d)
Review comment:
This is to prove that the test framework can distinguish -0.0 and 0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
