cloud-fan commented on a change in pull request #23388: [SPARK-26448][SQL]
retain the difference between 0.0 and -0.0
URL: https://github.com/apache/spark/pull/23388#discussion_r244079922
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
##########
@@ -594,7 +594,7 @@ abstract class AggregationQuerySuite extends QueryTest
with SQLTestUtils with Te
| max(distinct value1)
|FROM agg2
""".stripMargin),
- Row(-60, 70.0, 101.0/9.0, 5.6, 100))
+ Row(-60, 70, 101.0/9.0, 5.6, 100))
Review comment:
sum of int is long, we shouldn't use double here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
