mgaido91 commented on a change in pull request #23384: [SPARK-26443 ][CORE] Use 
ConfigEntry for hardcoded configs for history category.
URL: https://github.com/apache/spark/pull/23384#discussion_r244428984
 
 

 ##########
 File path: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
 ##########
 @@ -79,7 +79,7 @@ private[history] class HistoryServerArguments(conf: 
SparkConf, args: Array[Strin
       |
       |  spark.history.fs.logDirectory      Directory where app logs are stored
       |                                     (default: file:/tmp/spark-events)
-      |  spark.history.fs.updateInterval    How often to reload log data from 
storage
 
 Review comment:
   I see only now that it was deprecated, sorry. Then, this is ok, sorry for 
the comment.
   
   @dongjoon-hyun I meant that camel case notation for the last element is 
quite widespread also for other configs, so I didn't see the need for changing 
the notation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to