gatorsmile commented on a change in pull request #22999: [SPARK-20319][SQL] Already quoted identifiers are getting wrapped with additional quotes URL: https://github.com/apache/spark/pull/22999#discussion_r244501588
########## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ########## @@ -81,6 +81,10 @@ private case object OracleDialect extends JdbcDialect { case _ => None } + override def quoteIdentifier(colName: String): String = { + s""""${colName.stripPrefix("\"").stripSuffix("\"")}"""" Review comment: Could you check whether we issue a right message? https://issues.apache.org/jira/browse/SPARK-20319 The error message in the JIRA is pretty confusing. We added the quotes automatically and thus it looks weird to our end users. We need to figure out how to resolve the issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org