gatorsmile commented on a change in pull request #22999: [SPARK-20319][SQL]
Already quoted identifiers are getting wrapped with additional quotes
URL: https://github.com/apache/spark/pull/22999#discussion_r244543353
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala
##########
@@ -81,6 +81,10 @@ private case object OracleDialect extends JdbcDialect {
case _ => None
}
+ override def quoteIdentifier(colName: String): String = {
+ s""""${colName.stripPrefix("\"").stripSuffix("\"")}""""
Review comment:
See what we are doing in JDBCRelation's
verifyAndGetNormalizedPartitionColumn. Basically, before we calling
`quoteIdentifier `, we should already normalize the column names. Let us do the
similar things in `getInsertStatement`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
