liupc commented on a change in pull request #23444: [SPARK-26529]Add logs for
IOException when preparing local resource
URL: https://github.com/apache/spark/pull/23444#discussion_r245243575
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -780,10 +780,19 @@ private[spark] class Client(
props.store(writer, "Spark configuration.")
writer.flush()
confStream.closeEntry()
+ confArchive
+ } catch {
+ case e: IOException =>
+ logError(s"IOException occurred while writing to confArchive
$confArchive", e)
+ throw e
Review comment:
@HyukjinKwon because as explained in the jira
https://issues.apache.org/jira/browse/SPARK-26529, the message of some
IOException like "No space left exception" does not contains the writing path
information, so will delay the locating of the root cause(which local disk,
which files consuming large space), especially for large disk, to find out
which sub directories consuming large space is very slow.
Or for some disk input/output error, the path information also not provided,
one has to check all the disk to ensure the broken disk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
