srowen commented on a change in pull request #23278: [SPARK-24920][Core] Allow
sharing Netty's memory pool allocators
URL: https://github.com/apache/spark/pull/23278#discussion_r245485255
##########
File path: docs/configuration.md
##########
@@ -1505,6 +1505,16 @@ Apart from these, the following properties are also
available, and may be useful
<code>spark.rpc.lookupTimeout</code> if they are not configured.
</td>
</tr>
+<tr>
+ <td><code>spark.network.io.preferDirectBufs</code></td>
+ <td>true</td>
+ <td>
+ If enable then off-heap buffer allocations are prefered by the shared
ByteBuf allocators.
Review comment:
On a last look, there are probably a few small typos to change in the text,
but they're not a big deal: enable -> enabled, prefered -> preferred, ByteBuf
-> ByteBuffer. Should this be prefixed with "(Netty only)" like similar
properties, in the description? I don't know if we really need to mention Netty
as it's an implementation detail, and would be just as happy to remove "Netty"
from all the descriptions here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
