srowen commented on a change in pull request #23278: [SPARK-24920][Core] Allow
sharing Netty's memory pool allocators
URL: https://github.com/apache/spark/pull/23278#discussion_r245649581
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
##########
@@ -265,6 +265,16 @@ public boolean saslServerAlwaysEncrypt() {
return conf.getBoolean("spark.network.sasl.serverAlwaysEncrypt", false);
}
+ /**
+ * Flag indicating whether to share the pooled ByteBuf allocators between
the different Netty
+ * channels. If enabled then only two pooled ByteBuf allocators are created:
one where caching
+ * is allowed (for transport servers) and one where not (for transport
clients).
+ * When disabled a new allocator is created for each transport servers and
clients.
+ */
+ public Boolean sharedByteBufAllocators() {
+ return conf.getBoolean("spark.network.sharedByteBufAllocators.enabled",
true);
Review comment:
I believe he means it should go in Network.scala. @kiszk for consistency,
what about merging this then updating
https://github.com/apache/spark/pull/23416 which you have open right now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
