mgaido91 commented on a change in pull request #23392: [SPARK-26450][SQL] Avoid
rebuilding map of schema for every column in projection
URL: https://github.com/apache/spark/pull/23392#discussion_r245490697
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -456,16 +454,14 @@ case class HashAggregateExec(
val evaluateBufferVars = evaluateVariables(bufferVars)
// evaluate the aggregation result
ctx.currentVars = bufferVars
- val aggResults = declFunctions.map(_.evaluateExpression).map { e =>
- BindReferences.bindReference(e, aggregateBufferAttributes).genCode(ctx)
- }
+ val aggResults = bindReferences(declFunctions.map(_.evaluateExpression),
+ aggregateBufferAttributes).map(_.genCode(ctx))
val evaluateAggResults = evaluateVariables(aggResults)
// generate the final result
ctx.currentVars = keyVars ++ aggResults
val inputAttrs = groupingAttributes ++ aggregateAttributes
- val resultVars = resultExpressions.map { e =>
- BindReferences.bindReference(e, inputAttrs).genCode(ctx)
- }
+ val resultVars = bindReferences[Expression](resultExpressions,
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
