mgaido91 commented on a change in pull request #23392: [SPARK-26450][SQL] Avoid
rebuilding map of schema for every column in projection
URL: https://github.com/apache/spark/pull/23392#discussion_r245490750
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
##########
@@ -145,9 +146,9 @@ object FileFormatWriter extends Logging {
// SPARK-21165: the `requiredOrdering` is based on the attributes from
analyzed plan, and
// the physical plan may have different attribute ids due to optimizer
removing some
// aliases. Here we bind the expression ahead to avoid potential
attribute ids mismatch.
- val orderingExpr = requiredOrdering
- .map(SortOrder(_, Ascending))
- .map(BindReferences.bindReference(_, outputSpec.outputColumns))
+ val orderingExpr = bindReferences(
+ requiredOrdering.map(SortOrder(_, Ascending)),
+ outputSpec.outputColumns)
Review comment:
nit: on previous line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
