dongjoon-hyun commented on a change in pull request #23476:
[SPARK-26554][BUILD] Update `release-util.sh` to avoid GitBox fake 200 headers
URL: https://github.com/apache/spark/pull/23476#discussion_r245568775
##########
File path: dev/create-release/release-util.sh
##########
@@ -73,7 +73,9 @@ function fcreate_secure {
}
function check_for_tag {
- curl -s --head --fail "$ASF_REPO_WEBUI;a=commit;h=$1" >/dev/null
+ # Check HTML body messages instead of header status codes. Apache GitBox
returns
+ # a header with `200 OK` status code for both existing and non-existing tag
URLs
Review comment:
Ur, are you thinking of changing all `gitbox` to `github` together?
Actually, we changed them from `git-wip-us` to `github` yesterday.
- https://github.com/apache/spark/pull/23454
For tag checking, it's okay to use GitHub only. But, I'm afraid that
GitHub-only-usage is a potential violation of some Apache project policies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
