dongjoon-hyun commented on a change in pull request #23476:
[SPARK-26554][BUILD] Update `release-util.sh` to avoid GitBox fake 200 headers
URL: https://github.com/apache/spark/pull/23476#discussion_r245574264
##########
File path: dev/create-release/release-util.sh
##########
@@ -73,7 +73,9 @@ function fcreate_secure {
}
function check_for_tag {
- curl -s --head --fail "$ASF_REPO_WEBUI;a=commit;h=$1" >/dev/null
+ # Check HTML body messages instead of header status codes. Apache GitBox
returns
+ # a header with `200 OK` status code for both existing and non-existing tag
URLs
Review comment:
Ya. It was just my confusion. My bad. It looks completely okay.
- https://reference.apache.org/committer/github
> The ASF has a presence on GitHub at https://github.com/apache
- https://gitbox.apache.org/
> People that do not wish to utilize GitHub may continue using their ASF
credentials to push code to gitbox.apache.org - we do not mandate use of one of
the other.
Previously, `github` was able to be used at read-only pointers like
`pom.xml`'s `connection`. After GitBox setup, it's okay for read/write pointers
for all GitHub users.
For non-GitHub users (maybe BitBucket or GitLab users), we still use the
`gitbox` URL at write-access-required pointer like `pom.xml`'s
`developerConnection`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
